Update to timeline.js to fix YouTube embeds#695
Open
flynnmartin wants to merge 1 commit intoNUKnightLab:masterfrom
flynnmartin:patch-1
Open
Update to timeline.js to fix YouTube embeds#695flynnmartin wants to merge 1 commit intoNUKnightLab:masterfrom flynnmartin:patch-1
flynnmartin wants to merge 1 commit intoNUKnightLab:masterfrom
flynnmartin:patch-1
Conversation
When I tried a YouTube embed using the stock code, I couldn't get it to go by following the documentation for it. Changing the API calls to https and one URL seemed to fix the issue.
Member
|
There don't seem to be any problems embedding YouTube URLs in any of our test cases. Can you provide the value you entered for the media URL? for instance, I just used this YouTube URL on timeline.knightlab.com and got the expected behavior without your patch. |
Author
|
Unfortunately I used the "fixed" code on an internal-facing project at my last job, so I no longer have access to my original example. I'll see if I can come up with another one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I tried a YouTube embed using the stock code, I couldn't get it to go by following the documentation for it. Changing the API calls to https and one URL seemed to fix the issue.